git.openwrt.org Git - openwrt/openwrt.git/blob

   1 From 78bd03ee1f20a267d2c218884b66041b3508ac9c Mon Sep 17 00:00:00 2001
   2 From: Lorenzo Bianconi <lorenzo@kernel.org>
   3 Date: Wed, 18 Jun 2025 09:37:40 +0200
   4 Subject: [PATCH] net: airoha: Always check return value from
   5  airoha_ppe_foe_get_entry()
   6
   7 airoha_ppe_foe_get_entry routine can return NULL, so check the returned
   8 pointer is not NULL in airoha_ppe_foe_flow_l2_entry_update()
   9
  10 Fixes: b81e0f2b58be3 ("net: airoha: Add FLOW_CLS_STATS callback support")
  11 Reviewed-by: Simon Horman <horms@kernel.org>
  12 Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
  13 Link: https://patch.msgid.link/20250618-check-ret-from-airoha_ppe_foe_get_entry-v2-1-068dcea3cc66@kernel.org
  14 Signed-off-by: Jakub Kicinski <kuba@kernel.org>
  15 ---
  16  drivers/net/ethernet/airoha/airoha_ppe.c | 4 +++-
  17  1 file changed, 3 insertions(+), 1 deletion(-)
  18
  19 --- a/drivers/net/ethernet/airoha/airoha_ppe.c
  20 +++ b/drivers/net/ethernet/airoha/airoha_ppe.c
  21 @@ -819,8 +819,10 @@ airoha_ppe_foe_flow_l2_entry_update(stru
  22                 int idle;
  23
  24                 hwe = airoha_ppe_foe_get_entry(ppe, iter->hash);
  25 -               ib1 = READ_ONCE(hwe->ib1);
  26 +               if (!hwe)
  27 +                       continue;
  28
  29 +               ib1 = READ_ONCE(hwe->ib1);
  30                 state = FIELD_GET(AIROHA_FOE_IB1_BIND_STATE, ib1);
  31                 if (state != AIROHA_FOE_STATE_BIND) {
  32                         iter->hash = 0xffff;